Skip to content

Commit

Permalink
netfilter: nf_queue: remove unused hook entries pointer
Browse files Browse the repository at this point in the history
Its not used anywhere, so remove this.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Florian Westphal authored and ummakynes committed Jul 4, 2019
1 parent eca27f1 commit 0d9cb30
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
3 changes: 1 addition & 2 deletions include/net/netfilter/nf_queue.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,5 @@ nfqueue_hash(const struct sk_buff *skb, u16 queue, u16 queues_total, u8 family,
}

int nf_queue(struct sk_buff *skb, struct nf_hook_state *state,
const struct nf_hook_entries *entries, unsigned int index,
unsigned int verdict);
unsigned int index, unsigned int verdict);
#endif /* _NF_QUEUE_H */
2 changes: 1 addition & 1 deletion net/bridge/br_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ static int nf_hook_bridge_pre(struct sk_buff *skb, struct sk_buff **pskb)
kfree_skb(skb);
return RX_HANDLER_CONSUMED;
case NF_QUEUE:
ret = nf_queue(skb, &state, e, i, verdict);
ret = nf_queue(skb, &state, i, verdict);
if (ret == 1)
continue;
return RX_HANDLER_CONSUMED;
Expand Down
2 changes: 1 addition & 1 deletion net/netfilter/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ int nf_hook_slow(struct sk_buff *skb, struct nf_hook_state *state,
ret = -EPERM;
return ret;
case NF_QUEUE:
ret = nf_queue(skb, state, e, s, verdict);
ret = nf_queue(skb, state, s, verdict);
if (ret == 1)
continue;
return ret;
Expand Down
8 changes: 3 additions & 5 deletions net/netfilter/nf_queue.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ static void nf_ip6_saveroute(const struct sk_buff *skb,
}

static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state,
const struct nf_hook_entries *entries,
unsigned int index, unsigned int queuenum)
{
int status = -ENOENT;
Expand Down Expand Up @@ -225,12 +224,11 @@ static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state,

/* Packets leaving via this function must come back through nf_reinject(). */
int nf_queue(struct sk_buff *skb, struct nf_hook_state *state,
const struct nf_hook_entries *entries, unsigned int index,
unsigned int verdict)
unsigned int index, unsigned int verdict)
{
int ret;

ret = __nf_queue(skb, state, entries, index, verdict >> NF_VERDICT_QBITS);
ret = __nf_queue(skb, state, index, verdict >> NF_VERDICT_QBITS);
if (ret < 0) {
if (ret == -ESRCH &&
(verdict & NF_VERDICT_FLAG_QUEUE_BYPASS))
Expand Down Expand Up @@ -336,7 +334,7 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict)
local_bh_enable();
break;
case NF_QUEUE:
err = nf_queue(skb, &entry->state, hooks, i, verdict);
err = nf_queue(skb, &entry->state, i, verdict);
if (err == 1)
goto next_hook;
break;
Expand Down

0 comments on commit 0d9cb30

Please sign in to comment.