Skip to content

Commit

Permalink
dmaengine: mediatek: mtk-hsdma: Fix a resource leak in the error hand…
Browse files Browse the repository at this point in the history
…ling path of the probe function

'mtk_hsdma_hw_deinit()' should be called in the error handling path of the
probe function to undo a previous 'mtk_hsdma_hw_init()' call, as already
done in the remove function.

Fixes: 548c459 ("dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20201219124718.182664-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
tititiou36 authored and vinodkoul committed Dec 29, 2020
1 parent 8fb2879 commit 33cbd54
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/dma/mediatek/mtk-hsdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,7 @@ static int mtk_hsdma_probe(struct platform_device *pdev)
return 0;

err_free:
mtk_hsdma_hw_deinit(hsdma);
of_dma_controller_free(pdev->dev.of_node);
err_unregister:
dma_async_device_unregister(dd);
Expand Down

0 comments on commit 33cbd54

Please sign in to comment.