Skip to content

Commit

Permalink
of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing
Browse files Browse the repository at this point in the history
Introduced a stupid bug in commit 782bfd0 ("of: property: Improve
finding the supplier of a remote-endpoint property") due to a last minute
incorrect edit of "index !=0" into "!index". This patch fixes it to be
"index > 0" to match the comment right next to it.

Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/
Fixes: 782bfd0 ("of: property: Improve finding the supplier of a remote-endpoint property")
Signed-off-by: Saravana Kannan <saravanak@google.com>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/r/20240224052436.3552333-1-saravanak@google.com
Signed-off-by: Rob Herring <robh@kernel.org>
  • Loading branch information
Saravana Kannan authored and robherring committed Mar 1, 2024
1 parent 4e06ec0 commit 7cb50f6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/of/property.c
Original file line number Diff line number Diff line change
Expand Up @@ -1304,7 +1304,7 @@ static struct device_node *parse_remote_endpoint(struct device_node *np,
int index)
{
/* Return NULL for index > 0 to signify end of remote-endpoints. */
if (!index || strcmp(prop_name, "remote-endpoint"))
if (index > 0 || strcmp(prop_name, "remote-endpoint"))
return NULL;

return of_graph_get_remote_port_parent(np);
Expand Down

0 comments on commit 7cb50f6

Please sign in to comment.