Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the remove_front/back methods into remove_smallest/biggest #257

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Rename the remove_front/back methods into remove_smallest/biggest #257

merged 1 commit into from
Jul 25, 2023

Conversation

Kerollmops
Copy link
Member

This PR renames the remove_front and remove_back method into the clearer ones: remove_smallest and remove_biggest. These methods remove the n smallest or biggest values from the bitmaps.

ManyTheFish
ManyTheFish approved these changes Jul 25, 2023
View reviewed changes
Copy link

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@Kerollmops Kerollmops merged commit b8f3a6a into main Jul 25, 2023
4 checks passed
@Kerollmops Kerollmops deleted the rename-remove-front-back branch July 25, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerollmops @ManyTheFish