Adding a parameter to an *internal* constructor should not be considered a break.

[weirdan]

Change: vimeo/psalm@b2ccf24 (#8961)

BCC reports the following issue (the number of required arguments changed):

But it's:

1. a constructor (discussed in Are changes to the constructor really BC breaks? #497)
2. an internal method
3. of a final class

So this looks like a false-positive to me.

[weirdan]

This was reported with BCC 6.1, but the issue remains in 8.2 as well.

[Ocramius]

I'm confused by my own milestones 🤣

Taking a look shortly BTW: I think this may be a set-up problem in bin/

[Ocramius]

So, I tried it on vimeo/psalm with the patch you were referring to:

../../roave/BackwardCompatibilityCheck/bin/roave-backward-compatibility-check --from=origin/master --to=origin/pr/8961
<SNIP>
[BC] CHANGED: The number of required arguments for Psalm\Plugin\EventHandler\Event\StringInterpreterEvent#__construct() increased from 1 to 2
[BC] CHANGED: The number of required arguments for Psalm\Plugin\EventHandler\Event\BeforeAddIssueEvent#__construct() increased from 2 to 3
2 backwards-incompatible changes detected

I applied a config change:

diff --git a/bin/roave-backward-compatibility-check.php b/bin/roave-backward-compatibility-check.php
index 2edcf53..c261d6a 100644
--- a/bin/roave-backward-compatibility-check.php
+++ b/bin/roave-backward-compatibility-check.php
@@ -208,7 +208,7 @@ use function file_exists;
                                 )),
                             )),
                             new ClassBased\SkipClassBasedErrors(new ClassBased\MethodChanged(
-                                new MethodBased\SkipMethodBasedErrors(new MethodBased\OnlyPublicMethodChanged(
+                                new MethodBased\SkipMethodBasedErrors(new MethodBased\OnlyPublicMethodChanged(new MethodBased\ExcludeInternalMethod(
                                     new MethodBased\MultipleChecksOnAMethod(
                                         new MethodBased\SkipMethodBasedErrors(new MethodBased\MethodBecameFinal()),
                                         new MethodBased\SkipMethodBasedErrors(new MethodBased\MethodConcretenessChanged()),
@@ -226,7 +226,7 @@ use function file_exists;
                                             ),
                                         )),
                                     ),
-                                )),
+                                ))),
                             )),
                         ),
                     )),

../../roave/BackwardCompatibilityCheck/bin/roave-backward-compatibility-check --from=origin/master --to=origin/pr/8961
<SNIP>
No backwards-incompatible changes detected

Will commit change shortly :)

[Ocramius]

Handled in #724

[Ocramius]

Released BTW :)