Support PHP4-style constructors?

[asgrim]

#258 (comment)

TBH, could be php4 ctor... unsure though...
php4 ctors only work with non-namespaced code (hint)

[TomasVotruba]

Is this feature really needed in PHP 7.1 days?

[roukmoute]

Against because it's been now 8 years and 9 months ago that PHP 4 is at end of life.
If server is always in PHP 4, it is just... dangerous, it is urged to upgrade to a current version.

[Ocramius]

This has nothing to do with being against or for it: this is PHP behaviour and the reflection API does allow introspecting it.

…

On 15 May 2017 12:05 a.m., "Mathias STRASSER" ***@***.***> wrote: Against because it's been now 8 years and 9 months ago that PHP 4 is at end of life. If server is always in PHP 4, it is just... dangerous, it is urged to upgrade to a current version. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#263 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakIwHHjBgZA8BDG24iSnnb8DBp7Dtks5r53qjgaJpZM4MxsPG> .

[TomasVotruba]

I understand technical reasons and nice to have.
Is that a priority or is PHP 5 or 7 behavior support preffered?

[Ocramius]

This is PHP 7 behaviour too: https://3v4l.org/rgA0q

…

On 15 May 2017 12:10 a.m., "Tomáš Votruba" ***@***.***> wrote: I understand technical reasons and nice to have. Is that a priority or is PHP 5 behavior support preffered? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#263 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakOc7UdzycFcAkJCCzWXGzixozIf0ks5r53vdgaJpZM4MxsPG> .

[TomasVotruba]

I don't say it's impossible, I mean what's the use case?

[Ocramius]

The use-case is reflecting existing code: it could be the worst code in the world, but a constructor is a constructor, so it should be detected as such. Being opinionated about skipping it introduces false reflection behaviour, and therefore bugs. This library could be used to analyse code like WordPress', fwiw: it is not up to us to decide.

…

On 15 May 2017 12:15 a.m., "Tomáš Votruba" ***@***.***> wrote: I mean what's the use case. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#263 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakE4EfvTU8RxSSoDpNacGZOwLlfuUks5r53zogaJpZM4MxsPG> .

[TomasVotruba]

I see. I just ask, because I came over few bugs but didn't report them, because I though they are quite rare in practice and might rapidly slow down evolution of this package. That happens traditionally for many open-source packages I see.

I get feeling from this response, that everything is important here. Should I report every possible fail cases I came across then?

[Ocramius]

Yes please: if this library is not behaving like reflection, or at least providing equivalent information, then that's a bug.

…

On 15 May 2017 12:24 a.m., "Tomáš Votruba" ***@***.***> wrote: I see. I just ask, because I came over few bugs but didn't report them, because I though they are quite rare in practice and might rapidly slow down evolution of this package. That happens traditionally for many open-source packages I see. I get feeling from this response, that everything is important here. Should I report every possible fail cases I came across then? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#263 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakMO4y-0Q52z2YiAePDvXlodZpBGtks5r538RgaJpZM4MxsPG> .

[TomasVotruba]

Thanks, will do so.

[Ocramius]

Handled in #320