Fix support of Enum stubs from PHPStorm

[VincentLanglet]

Hi @Ocramius,

An (old) assert was added by @kukulich in 933dcb9

This one is not true anymore, cause PHPStorm stubs use @since on Enum like
JetBrains/phpstorm-stubs@2630c46#diff-11cfa64a565c311363b652c7494df2be636c9934afac14510bdd70e50d7044ceR6

Such error was discovered by the PHPStan CI which run on PHP 8.4 https://github.com/phpstan/phpstan-src/actions/runs/10680283358/job/29601421334?pr=3393 ; but I'm unsure how much work it would require so far to have a full Ci running on PHP 8.4. I can try in another PR if you want to.

[Ocramius]

@VincentLanglet are the stubs in here already bumped here? We bump them regularly, but it needs adjustments in composer.json too

[VincentLanglet]

@VincentLanglet are the stubs in here already bumped here? We bump them regularly, but it needs adjustments in composer.json too

No, those stubs are on master branch and but no tags are created yes.
JetBrains/phpstorm-stubs@v2024.2...master

Should I target the latest commit ?

[Ocramius]

Should I target the latest commit ?

For trying them out: yes.

For merging this (once fixed): needs to be a tagged version.

[VincentLanglet]

Should I target the latest commit ?

For trying them out: yes.

Done. I also tried to add a PHP 8.4 Ci (for testing purpose), because the error occured only on PHP 8.4 PHPStan ci. (cf https://github.com/phpstan/phpstan-src/actions/runs/10680283358/job/29601421334?pr=3393)

(Not sure if there is an easy way to avoid waiting for workflow approval at every commit so I try to offer an easy-merge PR #1446)

[kukulich]

@VincentLanglet You can remove the PHP 8.4 changes and use random extension for unit tests.

[VincentLanglet]

I reworked the PR @Ocramius,

Since I dunno when a new tag of PHPStorm stubs will be released,

• I added a test with the enum case of random extension => tests are failing
• I added the fix in a new commit => tests are green

This way it should be merge-able now, without waiting for a PHPStorm stub new tag.
(and https://github.com/ondrejmirtes/BetterReflection will be able to rebase the fix too)

Also, I discovered you'll need a fix for SplObjectStorage in PHP 8.4 so I opened another PR #1448.

[Ocramius]

Thanks @VincentLanglet!