Fixed hooks parameters and return types #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulich
force-pushed
the
hooks
branch
2 times, most recently
from
723c669 to
ab81459
Compare
Ocramius
approved these changes
Dec 12, 2024
Comment on lines
-42
to
+48
| private array $parameters; | ||
| protected array $parameters; | ||
|
|
||
| /** @psalm-allow-private-mutation */ | ||
| private bool $returnsReference; | ||
|
|
||
| /** @psalm-allow-private-mutation */ | ||
| private ReflectionNamedType|ReflectionUnionType|ReflectionIntersectionType|null $returnType; | ||
| protected ReflectionNamedType|ReflectionUnionType|ReflectionIntersectionType|null $returnType; |
There was a problem hiding this comment.
Not a fan of using protected (plus a trait), so we may really need to do some changing here in the next versions.
| #[DataProvider('getPropertyHookReturnTypeProvider')] | ||
| public function testGetPropertyHookReturnType(string $propertyName, string|null $returnType): void | ||
| { | ||
| $reflector = new DefaultReflector(new SingleFileSourceLocator(__DIR__ . '/../Fixture/PropertyHooks.php', $this->astLocator)); |
There was a problem hiding this comment.
One note on the design of these tests: having everything inside a third-party file makes them a bit harder to locate when jumping around source, compared to using a string locator inlined with the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just another bug found by @ondrejmirtes