Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asymmetric visibility fixes around implicit public, private and protected visibility #1472

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

kukulich
Copy link
Collaborator

No description provided.

@kukulich kukulich added the bug label Dec 30, 2024
@kukulich kukulich force-pushed the asymetric-visibility branch from 9f2a877 to 5dde1c9 Compare December 30, 2024 12:08
@Ocramius
Copy link
Member

I merged + released #1472 meanwhile.

Will change target branch here.

@Ocramius Ocramius changed the base branch from 6.50.x to 6.51.x December 30, 2024 12:44
@kukulich kukulich marked this pull request as ready for review December 30, 2024 12:55
@kukulich kukulich force-pushed the asymetric-visibility branch from 5dde1c9 to b3dc8b1 Compare December 30, 2024 12:57
@Ocramius Ocramius added this to the 6.51.0 milestone Dec 30, 2024
@Ocramius Ocramius changed the title Asymmetric visibility fixes Asymmetric visibility fixes around implicit public, private and protected visibility Dec 30, 2024
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kukulich!

@Ocramius Ocramius self-assigned this Dec 30, 2024
@Ocramius Ocramius merged commit 54c3dfb into Roave:6.51.x Dec 30, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants