Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require minimum of PHP 7, enabling tests on PHP 7.1 #226

Merged
merged 4 commits into from
Dec 24, 2016
Merged

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Nov 30, 2016

Fixes #221

Rebase when #217 is merged

@asgrim asgrim added this to the 1.3.0 milestone Nov 30, 2016
@asgrim asgrim self-assigned this Nov 30, 2016
@asgrim
Copy link
Member Author

asgrim commented Nov 30, 2016

Oh yay there's some fun going on here.

Two issues I've spotted:

? not supported, needs PHP Parser 3 most likely needs #217 to be merged

1) BetterReflectionTest\Reflection\ReflectionParameterTest::testGetDefaultValueAsString with data set #1 ('12.3', '12.300000000000001')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-12.300000000000001
+12.3

@asgrim asgrim mentioned this pull request Nov 30, 2016
@asgrim asgrim added the WIP label Dec 1, 2016
@@ -3,7 +3,7 @@
"description": "Better Reflection - an improved code reflection API",
"license": "MIT",
"require": {
"php": "^7.0|^7.1",
"php": "^7.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm, I know it's not technically needed, but I think it helps; especially when php itself isn't actually semver. In fact, perhaps better to be 7.0.*|7.1.* heh?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asgrim indeed, better choice. Updating now.

@Ocramius Ocramius removed the WIP label Dec 24, 2016
@Ocramius Ocramius merged commit 4a8b464 into master Dec 24, 2016
@Ocramius Ocramius deleted the require-php-7 branch December 24, 2016 13:31
@Ocramius Ocramius assigned Ocramius and unassigned asgrim Dec 24, 2016
@asgrim asgrim modified the milestones: 1.3.0, 2.0.0 Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants