-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require minimum of PHP 7, enabling tests on PHP 7.1 #226
Conversation
Oh yay there's some fun going on here. Two issues I've spotted:
|
6a481fb
to
b311582
Compare
@@ -3,7 +3,7 @@ | |||
"description": "Better Reflection - an improved code reflection API", | |||
"license": "MIT", | |||
"require": { | |||
"php": "^7.0|^7.1", | |||
"php": "^7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmm, I know it's not technically needed, but I think it helps; especially when php
itself isn't actually semver. In fact, perhaps better to be 7.0.*|7.1.*
heh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asgrim indeed, better choice. Updating now.
… semver-compliant
Fixes #221
Rebase when #217 is merged