Fix self and parent hinted ReflectionParameter class reference
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
previously requested changes
Jan 9, 2017
| return null; | ||
| } | ||
|
|
||
| if (!$this->reflector instanceof ClassReflector) { | ||
| throw new \RuntimeException('Unable to reflect class type because we were not given a ClassReflector'); | ||
| } | ||
|
|
||
| if ($hint instanceof Types\Self_) { |
There was a problem hiding this comment.
This can go before the if (!$this->reflector instanceof ClassReflector) { check
| { | ||
| $content = '<?php class Foo { public function myMethod(self $param) {} }'; | ||
|
|
||
| $reflector = new ClassReflector(new AggregateSourceLocator([ |
There was a problem hiding this comment.
don't need PhpInternalSourceLocator do we ?
Ocramius
requested changes
Jan 10, 2017
| @@ -504,10 +504,14 @@ public function getDefaultValueConstantName() | |||
| public function getClass() | |||
| { | |||
| $hint = $this->getTypeHint(); | |||
| if (!($hint instanceof Types\Object_)) { | |||
| if (!($hint instanceof Types\Object_ || $hint instanceof Types\Self_)) { | |||
There was a problem hiding this comment.
There should also be a parent hint
Ocramius
requested changes
Jan 13, 2017
| return $this->getDeclaringClass(); | ||
| } | ||
|
|
||
| if ('parent' === $hint->getFqsen()->getName()) { |
There was a problem hiding this comment.
Wait, there's no AST node for this? If so, can you please add a comment about it?
There was a problem hiding this comment.
Moved to phpDocumentor/TypeResolver#27
| { | ||
| $content = '<?php class Foo { public function myMethod(self $param) {} }'; | ||
|
|
||
| $reflector = new ClassReflector(new AggregateSourceLocator([ |
Ocramius
approved these changes
Jan 13, 2017
Ocramius
changed the title
self hinted ReflectionParameter class referenceself and parent hinted ReflectionParameter class reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking #240