create reflection parameter from closure #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
requested changes
Mar 31, 2017
| * @param string $parameterName | ||
| * @return ReflectionParameter | ||
| */ | ||
| public static function createFormClosure(\Closure $closure, $parameterName) |
There was a problem hiding this comment.
- typo in method name
createFromClosure - also please add type declarations (
string $parameterNameand: ReflectionParameter) (I'm working on adding type declarations everywhere else as we're min PHP 7 for next release now)
| { | ||
| $parameterInfo = ReflectionParameter::createFormClosure(function ($a) {}, 'a'); | ||
|
|
||
| $this->assertInstanceOf(ReflectionParameter::class, $parameterInfo); |
There was a problem hiding this comment.
please use self::assertInstanceOf
| $parameterInfo = ReflectionParameter::createFormClosure(function ($a) {}, 'a'); | ||
|
|
||
| $this->assertInstanceOf(ReflectionParameter::class, $parameterInfo); | ||
| $this->assertSame('a', $parameterInfo->getName()); |
|
fixed the minor changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #255