Disallow build failures on PHP 7.2 #392

kukulich · 2018-01-02T21:17:26Z

No description provided.

kukulich · 2018-01-02T21:23:15Z

Hmm, Travis uses PHP 7.1.1 but the bug in SoapClient is fixed in 7.1.2 :(

asgrim · 2018-01-31T09:22:23Z

@kukulich Hmm, what's the SoapClient issue? I just restarted the build but fails again:

1) Roave\BetterReflectionTest\SourceLocator\Type\PhpInternalSourceLocatorTest::testAllGeneratedStubsAreInSyncWithInternalReflectionClasses with data set "SoapClient" ('SoapClient')
SoapClient#__setSoapHeaders.soapheaders
Failed asserting that true matches expected false.
/home/travis/build/Roave/BetterReflection/test/unit/SourceLocator/Type/PhpInternalSourceLocatorTest.php:400
/home/travis/build/Roave/BetterReflection/test/unit/SourceLocator/Type/PhpInternalSourceLocatorTest.php:357
/home/travis/build/Roave/BetterReflection/test/unit/SourceLocator/Type/PhpInternalSourceLocatorTest.php:303
/home/travis/build/Roave/BetterReflection/test/unit/SourceLocator/Type/PhpInternalSourceLocatorTest.php:209

$ php --version
PHP 7.1.11 (cli) (built: Oct 26 2017 16:25:55) ( ZTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.1.11, Copyright (c) 1999-2017, by Zend Technologies
    with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans

kukulich · 2018-01-31T09:31:38Z

@asgrim It caused by this: https://github.com/php/php-src/blob/PHP-7.1/NEWS#L170

Travis still runs PHP 7.1.11 unfortunately :(

I can add if to the test probably for older PHP.

asgrim · 2018-01-31T09:47:02Z

Ah sorry, your comment suggested it was fixed in 7.1.2 ;) Gotcha. Then yes indeed, we're going to need to hack it to support both versions unfortunately as someone may be trying to reflect SoapClient with BR :/

See https://bugs.php.net/bug.php?id=75464

kukulich · 2018-01-31T10:26:15Z

@asgrim Solved :)

asgrim · 2018-01-31T14:55:33Z

test/unit/SourceLocator/Type/PhpInternalSourceLocatorTest.php

@@ -397,7 +397,12 @@ private function assertSameParameterAttributes(
        }
        //self::assertSame($original->allowsNull(), $stubbed->allowsNull()); @TODO WTF?
        self::assertSame($original->canBePassedByValue(), $stubbed->canBePassedByValue(), $parameterName);
-        self::assertSame($original->isOptional(), $stubbed->isOptional(), $parameterName);
+
+        if (! ($parameterName === 'SoapClient#__setSoapHeaders.soapheaders' && PHP_VERSION_ID < 70112)) {


Disgusting, but works 👍

kukulich force-pushed the php72 branch from 98c2e3f to dc29482 Compare January 2, 2018 21:19

kukulich force-pushed the php72 branch from f383724 to 79a908b Compare January 5, 2018 12:35

No allowed failures on PHP 7.2 anymore

2d4651b

kukulich force-pushed the php72 branch from 79a908b to 8fe3cb7 Compare January 26, 2018 10:44

asgrim assigned kukulich Jan 31, 2018

asgrim added the enhancement label Jan 31, 2018

kukulich force-pushed the php72 branch from 8fe3cb7 to 685724e Compare January 31, 2018 09:39

kukulich force-pushed the php72 branch from 685724e to e228708 Compare January 31, 2018 09:55

kukulich added 2 commits January 31, 2018 11:10

Fixed SoapClient stub

9cce4d5

See https://bugs.php.net/bug.php?id=75464

AppVeyor configuration tuning so we can test both PHP 7.1 and PHP 7.2

5e85f51

kukulich force-pushed the php72 branch from e228708 to 5e85f51 Compare January 31, 2018 10:11

asgrim approved these changes Jan 31, 2018

View reviewed changes

asgrim added this to the 2.1.0 milestone Jan 31, 2018

asgrim merged commit 2ba5247 into Roave:master Jan 31, 2018

kukulich deleted the php72 branch January 31, 2018 15:02

Ocramius modified the milestones: 2.1.0, 3.0.0 Feb 5, 2018

Ocramius changed the title ~~No allowed failures on PHP 7.2 anymore~~ Disallow failures on PHP 7.2 May 26, 2018

Ocramius changed the title ~~Disallow failures on PHP 7.2~~ Disallow build failures on PHP 7.2 May 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow build failures on PHP 7.2 #392

Disallow build failures on PHP 7.2 #392

kukulich commented Jan 2, 2018

kukulich commented Jan 2, 2018

asgrim commented Jan 31, 2018

kukulich commented Jan 31, 2018

asgrim commented Jan 31, 2018

kukulich commented Jan 31, 2018

asgrim Jan 31, 2018

Disallow build failures on PHP 7.2 #392

Disallow build failures on PHP 7.2 #392

Conversation

kukulich commented Jan 2, 2018

kukulich commented Jan 2, 2018

asgrim commented Jan 31, 2018

kukulich commented Jan 31, 2018

asgrim commented Jan 31, 2018

kukulich commented Jan 31, 2018

asgrim Jan 31, 2018

Choose a reason for hiding this comment