Compatibility for ReflectionFunctionAbstract and ReflectionFunction

docs/compatibility.md

@@ -26,8 +26,8 @@ The progress of compatibility can also be tracked in issue [#7](https://github.c
 | getProperty | :heavy_check_mark: Yes |
 | getShortName | :heavy_check_mark: Yes |
 | getStartLine | todo |
-| getStaticProperties | todo |
-| getStaticPropertyValue | :x: No - would require an instance (#14) |
+| getStaticProperties | :x: No - would require loading (#14) |
+| getStaticPropertyValue | :x: No - would require loading (#14) |
 | getTraitAliases | todo |
 | getTraitNames | todo |
 | getTraits | todo |
@@ -50,35 +50,35 @@ The progress of compatibility can also be tracked in issue [#7](https://github.c
 | newInstance | todo |
 | newInstanceArgs | todo |
 | newInstanceWithoutConstructor | todo |
-| setStaticPropertyValue | :x: No - would require an instance (#14) |
+| setStaticPropertyValue | :x: No - would require loading (#14) |
 
 ## ReflectionFunctionAbstract
 
 | Method | Supported |
 |--------|-----------|
-| getClosureScopeClass | todo |
-| getClosureThis | todo |
+| getClosureScopeClass | :x: No - would require loading of the method itself (#14) |
+| getClosureThis | :x: No - would require loading of the method itself (#14) |
 | getDocComment | :heavy_check_mark: Yes |
-| getEndLine | todo |
-| getExtension | todo |
-| getExtensionName | todo |
+| getEndLine | :heavy_check_mark: Yes |
+| getExtension | :x: No - extensions are not supported (#15) |
+| getExtensionName | :x: No - extensions are not supported (#15) |
 | getFileName | :heavy_check_mark: Yes |
 | getName | :heavy_check_mark: Yes |
-| getNamespaceName | todo |
+| getNamespaceName | :heavy_check_mark: Yes |
 | getNumberOfParameters | :heavy_check_mark: Yes |
 | getNumberOfRequiredParameters | :heavy_check_mark: Yes |
 | getParameters | :heavy_check_mark: Yes |
-| getShortName | todo |
-| getStartLine | todo |
-| getStaticVariables | todo |
-| inNamespace | todo |
-| isClosure | todo |
-| isDeprecated | todo |
-| isGenerator | todo |
-| isInternal | todo |
-| isUserDefined | todo |
-| isVariadic | todo |
-| returnsReference | todo |
+| getShortName | :heavy_check_mark: Yes |
+| getStartLine | :heavy_check_mark: Yes |
+| getStaticVariables | :x: No - would require loading (#14) |
+| inNamespace | :heavy_check_mark: Yes |
+| isClosure | :heavy_check_mark: Yes - but see issue (#37) |
+| isDeprecated | :heavy_check_mark: Yes - but see issue (#38) |
+| isGenerator | :heavy_check_mark: Yes |
+| isInternal | :heavy_check_mark: Yes - but see issue (#38) |
+| isUserDefined | :heavy_check_mark: Yes |
+| isVariadic | :heavy_check_mark: Yes |
+| returnsReference | :heavy_check_mark: Ye |
 
 ## ReflectionMethod
 
@@ -129,7 +129,7 @@ The progress of compatibility can also be tracked in issue [#7](https://github.c
 | getClosure | :x: No - would require actual compilation of the AST (#14) |
 | invoke | :x: No - would require loading of the function itself (#14) |
 | invokeArgs | :x: No - would require loading of the function itself (#14) |
-| isDisabled | todo |
+| isDisabled | :heavy_check_mark: Yes - but see issue (#38) |
 | _inherited methods_ | see `ReflectionFunctionAbstract` |
 
 ## ReflectionProperty

src/Identifier/IdentifierType.php

@@ -4,17 +4,20 @@
 
 use PhpParser\Node;
 use BetterReflection\Reflection\ReflectionClass;
+use BetterReflection\Reflection\ReflectionFunction;
 use BetterReflection\Reflection\Reflection;
 
 class IdentifierType
 {
     const IDENTIFIER_CLASS = ReflectionClass::class;
+    const IDENTIFIER_FUNCTION = ReflectionFunction::class;
 
     /**
      * @var string[]
      */
     private $validTypes = [
         self::IDENTIFIER_CLASS,
+        self::IDENTIFIER_FUNCTION,
     ];
 
     /**
@@ -50,10 +53,12 @@ public function getName()
     public function isMatchingReflector(Reflection $reflector)
     {
         if ($this->name == self::IDENTIFIER_CLASS) {
-            return $reflector instanceof ReflectionClass;
+            return ($reflector instanceof ReflectionClass);
         }
 
-        // @todo add more type checks
+        if ($this->name == self::IDENTIFIER_FUNCTION) {
+            return ($reflector instanceof ReflectionFunction);
+        }
 
         return false;
     }

src/Reflection/ReflectionClass.php

@@ -52,8 +52,8 @@ private function __construct()
      * Create from a Class Node
      *
      * @param ClassNode $node
-     * @param NamespaceNode $namespace optional - if omitted, we assume it is global namespaced class
-     * @param string $filename If set, this is the filename the class was declared in
+     * @param NamespaceNode|null $namespace optional - if omitted, we assume it is global namespaced class
+     * @param string|null $filename If set, this is the filename the class was declared in
      * @return ReflectionClass
      */
     public static function createFromNode(

src/Reflection/ReflectionFunction.php

@@ -0,0 +1,43 @@
+<?php
+
+namespace BetterReflection\Reflection;
+
+use PhpParser\Node\Stmt\Function_ as FunctionNode;
+use PhpParser\Node\Stmt\Namespace_ as NamespaceNode;
+
+class ReflectionFunction extends ReflectionFunctionAbstract implements Reflection
+{
+    /**
+     * @param FunctionNode $node
+     * @param NamespaceNode|null $namespaceNode
+     * @param string|null $filename
+     * @return ReflectionMethod
+     */
+    public static function createFromNode(
+        FunctionNode $node,
+        NamespaceNode $namespaceNode = null,
+        $filename = null
+    ) {
+        $method = new self($node);
+
+        $method->populateFunctionAbstract($node, $namespaceNode, $filename);
+
+        return $method;
+    }
+
+    /**
+     * Check to see if this function has been disabled (by the PHP INI file
+     * directive `disable_functions`)
+     *
+     * Note - we cannot reflect on internal functions (as there is no PHP source
+     * code we can access. This means, at present, we can only EVER return false
+     * from this function, because you cannot disable user-defined functions.
+     *
+     * @see http://php.net/manual/en/ini.core.php#ini.disable-functions
+     * @return bool
+     */
+    public function isDisabled()
+    {
+        return false;
+    }
+}