Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error on anonymous classes with interfaces #433

Conversation

prisis
Copy link
Contributor

@prisis prisis commented Jun 14, 2018

should i send the same fix for v2?

@prisis prisis force-pushed the fixed-error-on-anonymous-classes-with-interface branch from 6ca5c03 to 3d24651 Compare June 14, 2018 19:14
@prisis prisis changed the base branch from master to 3.0.x June 14, 2018 19:17
@prisis prisis force-pushed the fixed-error-on-anonymous-classes-with-interface branch from a545e33 to 51d88ee Compare June 15, 2018 18:11
@prisis
Copy link
Contributor Author

prisis commented Jun 15, 2018

Something is wrong with travis ...

@asgrim
Copy link
Member

asgrim commented Jun 16, 2018

@prisis #425 that was causing the test failures here has now been merged, please could you rebase this PR to the latest master?

@asgrim
Copy link
Member

asgrim commented Jun 16, 2018

No need to patch v2; it's not a security fix so I think we're good, thanks 👍

@prisis prisis force-pushed the fixed-error-on-anonymous-classes-with-interface branch from 51d88ee to ebbd50e Compare June 16, 2018 10:54
@prisis prisis changed the base branch from 3.0.x to master June 16, 2018 10:55
@prisis
Copy link
Contributor Author

prisis commented Jun 16, 2018

done and changed the base brach to master

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit 6a9639e into Roave:master Jun 16, 2018
@Ocramius
Copy link
Member

Thanks @prisis!

@asgrim asgrim added this to the 3.1.0 milestone Jun 16, 2018
@prisis prisis deleted the fixed-error-on-anonymous-classes-with-interface branch August 28, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants