Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer-specific source locator builder #461

Merged
merged 29 commits into from
Apr 22, 2019
Merged

Composer-specific source locator builder #461

merged 29 commits into from
Apr 22, 2019

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Mar 20, 2019 •
edited
Loading

Fixes #442

TODOs:

  • testing
  • do we want beberlei/assert? removed
  • a composer.json-only loader (no vendor/ considered)
  • docs

@Ocramius Ocramius self-assigned this Mar 20, 2019
@Ocramius
Copy link
Member Author

Whew, my idea for Roave/BackwardCompatibilityCheck#110 is indeed working here: analysing a whole reflection tree is an order of magnitude faster this way, although we may still speed up things by nod jumping through the source locators.

@Ocramius
Copy link
Member Author

Note: still fails when trying to locate symfony/console or doctrine/common classes, so I might need to inspect this further

@Ocramius Ocramius mentioned this pull request Apr 16, 2019
Closed
@Ocramius Ocramius force-pushed the feature/composer-source-locators branch from e7d9baf to bf02b76 Compare April 20, 2019 08:00
Ocramius added 24 commits April 22, 2019 05:23
@Ocramius
Spec for an API that, given a set of psr-4 mappings, can look up all …
5f629d6 
…directories in those mappings
@Ocramius
The constructor of the Psr4Mapping definition must produce equivale…
976e256 
…nt instances for equivalent input values
@Ocramius
Verify PSR-4 class lookups against a data-provider
2b3129c
@Ocramius
PSR-4 lookups for non-class identifiers should fail
73b1719
@Ocramius
Abstraction for a PSR-4 mapping data structure
fa64531
@Ocramius
Implemented a PSR-4-based source locator
a9879ce
@Ocramius
PSR-0 mapping definitions abstraction
bc46762
@Ocramius
Common abstraction for lookups via PSR autoloader mappings
f6b2cc0
@Ocramius
Rewrote PSR-4 locator to work with any PSR autoload mappings
c153a9e
@Ocramius
Prototype for an utility that builds a composer autoloader given a pr…
0f410a6 
…oject path
@Ocramius
Corrected callback parameter order
132dca5
@Ocramius
Corrected reference to installed.json
9d04388
@Ocramius
Prefix all autoload paths with their installation path
adb8291
@Ocramius
Implemented a source locator factory for installed.json (only)
a10d2ee
@Ocramius
Packages (generally) live under vendor/, which I forgot to add to p…
e46a99b 
…refix
@Ocramius
Corrected SingleFileSourceLocator instantiation/merging with parent…
1f3e44f 
… array
@Ocramius
Stub source locator builder for composer.json paths *ONLY*
2ce44a5
@Ocramius
Need beberlei/assert for these added monstruosity to work
8f83091
@Ocramius
Clarifying on why a PsrAutoloaderLocator has an empty try-catch on …
da0a1b3 
…purpose
@Ocramius
Moved composer-locator utilities to a Factory\ sub-namespace
2420548
@Ocramius
Extensive test coverage and exception specificity for `MakeLocatorFor…
e11272a 
…ComposerJsonAndInstalledJson`
@Ocramius
Added ext-json requirement to composer.json - needed for `json_de…
a114863 
…code()`
@Ocramius
Extensive tests for MakeLocatorForComposerJson factory
da0e599
@Ocramius
Extensive tests for MakeLocatorForInstalledJson factory
0364914
@Ocramius Ocramius force-pushed the feature/composer-source-locators branch from bf02b76 to 76b0350 Compare April 22, 2019 04:44
@Ocramius Ocramius added this to the 3.4.0 milestone Apr 22, 2019
@Ocramius Ocramius requested review from asgrim and malukenho April 22, 2019 04:45
@Ocramius
Copy link
Member Author

@kukulich this is now ready - if you are working on the repo these days, can you give it a quick skim please?

@Ocramius Ocramius changed the title WIP: composer-specific source locator builder Composer-specific source locator builder Apr 22, 2019
@Ocramius Ocramius mentioned this pull request Apr 22, 2019
Closed
@kukulich
Copy link
Collaborator

Looks good to me 👍

@Ocramius
Copy link
Member Author

Thanks @kukulich: preparing a release in the next hours 👍

@Ocramius Ocramius merged commit 68f10dc into master Apr 22, 2019
@Ocramius Ocramius deleted the feature/composer-source-locators branch April 22, 2019 18:27
@Ocramius Ocramius mentioned this pull request Apr 23, 2019
Merged
uzibhalepu added a commit to uzibhalepu/BackwardCompatibilityCheck that referenced this pull request Aug 6, 2024
@uzibhalepu @Ocramius
Experimental usage of roave/better-reflection composer source-locators
8968a87 
Requires Roave/BetterReflection#461
Nyholm pushed a commit to Nyholm/BackwardCompatibilityCheck that referenced this pull request Oct 7, 2024
@Ocramius
Experimental usage of roave/better-reflection composer source-locators
e496982 
Requires Roave/BetterReflection#461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgrim asgrim Awaiting requested review from asgrim

@malukenho malukenho Awaiting requested review from malukenho

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
3.4.0
2 participants
@Ocramius @kukulich