Allow generators as parameters to setMultiple #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
force-pushed
the
allow-generators-as-parameters
branch
from
bd93c7f
to
f376158
Compare
Ocramius
approved these changes
Jan 20, 2017
Ocramius
requested changes
Jan 20, 2017
| @@ -25,8 +25,6 @@ protected function setUp() : void | |||
| parent::setUp(); | |||
|
|
|||
| // @todo: Let's make these tests pass | |||
| $this->skippedTests['testSetMultipleWithGenerator'] = true; | |||
There was a problem hiding this comment.
Don't we also need unit tests in our suite?
asgrim
force-pushed
the
allow-generators-as-parameters
branch
from
f376158
to
6826054
Compare
Ocramius
approved these changes
Jan 20, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of #8.