Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement endroid/qr-code support #40

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

SavageCore
Copy link
Contributor

I have left out readme changes as it needs updating further, default provider still listed as ImageChartsQRCodeProvider for example.

Usage

$qrProvider = new RobThree\Auth\Providers\Qr\EndroidQrCodeProvider('ffffff', '0000000', 0, 'H');
$tfa = new RobThree\Auth\TwoFactorAuth('My Company', 6, 30, 'sha1', $qrProvider);

@RobThree
Copy link
Owner

RobThree commented Jan 2, 2020

I am really not very much familiar with the whole composer thing; shouldn't this require a reference in the composer.json file as it's a dependency?

@MasterOdin
Copy link
Contributor

Anything that can be helped with to see this merged and incorporated into a new release? Similar to the suggestion in #39, composer.json can be modified to use the suggest block to propose dependencies that will enhance the package, but are not strictly necessary:

"suggest": {
  "endroid/qr-code": "Needed for EndroidQrCodeProvider"
}

Then optionally install it to require-dev to be used for writing a test case with it.

@RobThree RobThree merged commit f0136c9 into RobThree:master Sep 27, 2020
RobThree added a commit that referenced this pull request Sep 27, 2020
@RobThree
Copy link
Owner

I have merged this one, as wel as #39. If someone would like to update the README and make a PR that would be appreciated!

@MasterOdin
Copy link
Contributor

sure, I can do that.

@SavageCore SavageCore deleted the feature/endroidqrcode branch September 27, 2020 22:40
@willpower232
Copy link
Collaborator

thanks @MasterOdin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants