Test specific provider #86
Conversation
willpower232
force-pushed
the
test-specific-provider
branch
from
7993e0e to
cb45226
Compare
|
|
||
| - uses: ramsey/composer-install@v1 | ||
|
|
||
| - run: composer require bacon/bacon-qr-code |
There was a problem hiding this comment.
Why not just make it a dev dependency? Same with the other third-party libraries? They're necessary to run the full test suite, and would avoid having an independent workflow across all supported PHP versions for this one (or several) external dependencies? Within the dev dependencies, you then can also specify the range you wish to test against (e.g. "bacon/bacon-qr-code": "^1 | ^2") and then within the composer install line pass --prefer-lowest when testing against PHP 5.6, where ^1 is only to test that the exception throws.
There was a problem hiding this comment.
in reality, the end user would only install bacon or endroid so the tests should recreate that environment
also adding them both as development dependencies could get complicated as endroid relies on bacon
|
I'll be having vacation the week between christmas and new year's eve. I'm hoping to get around to this and really be able to take a few minutes and sit down and have a decent look at this. I'm sorry for the lack of response. |
|
no worries @RobThree I wanted to get some progress on the PHP 8.1 thing and this issue and finally had some moments and a working laptop to do it in 😅 |
|
From what I see and understand, this looks good to me! I'll leave the honour of pressing the "Merge Pull Request" button to you @willpower232! Great work (as usual), thank you! |
As this library supports two third party QR code generators "out of the box", it is a good idea to test them but separately as the composer dependencies could get a bit messed up.
This PR lays out a mechanism for doing so (and fixes a little problem as well).