Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$code should have (string) type. (int) will produce always false. #95

Closed
wants to merge 1 commit into from
Closed

$code should have (string) type. (int) will produce always false. #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/TwoFactorAuth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public function createSecret($bits = 80, $requirecryptosecure = true)
throw new TwoFactorAuthException('RNG provider is not cryptographically secure');
}
$rnd = $rngprovider->getRandomBytes($bytes);
for ($i = 0; $i < $bytes; $i++) {
for ($i = 0; $i < $bytes; ++$i) {
$secret .= self::$_base32[ord($rnd[$i]) & 31]; //Mask out left 3 bits for 0-31 values
}
return $secret;
Expand Down Expand Up @@ -151,10 +151,10 @@ public function verifyCode($secret, $code, $discrepancy = 1, $time = null, &$tim
// verified a code is correct. We use the timeslice variable to hold either 0 (no match) or the timeslice
// of the match. Each iteration we either set the timeslice variable to the timeslice of the match
// or set the value to itself. This is an effort to maintain constant execution time for the code.
for ($i = -$discrepancy; $i <= $discrepancy; $i++) {
for ($i = -$discrepancy; $i <= $discrepancy; ++$i) {
$ts = $timestamp + ($i * $this->period);
$slice = $this->getTimeSlice($ts);
$timeslice = $this->codeEquals($this->getCode($secret, $ts), $code) ? $slice : $timeslice;
$timeslice = $this->codeEquals($this->getCode($secret, $ts), (string)$code) ? $slice : $timeslice;
}

return $timeslice > 0;
Expand All @@ -177,7 +177,7 @@ private function codeEquals($safe, $user)
// we don't leak information about the difference of the two strings.
if (strlen($safe) === strlen($user)) {
$result = 0;
for ($i = 0; $i < strlen($safe); $i++) {
for ($i = 0; $i < strlen($safe); ++$i) {
$result |= (ord($safe[$i]) ^ ord($user[$i]));
}
return $result === 0;
Expand Down