Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo ESP32 SPI interface #15

Closed
RobTillaart opened this issue Nov 20, 2023 · 0 comments · Fixed by #16
Closed

redo ESP32 SPI interface #15

RobTillaart opened this issue Nov 20, 2023 · 0 comments · Fixed by #16
Assignees
@RobTillaart
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@RobTillaart
Copy link
Owner

ESP32-S3 does not do VSPI.
ESP32 dependency should be minimized
(remove HSPI/VSPI references, see MCP_DAC #24)
@RobTillaart RobTillaart self-assigned this Nov 20, 2023
@RobTillaart RobTillaart added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 20, 2023
RobTillaart added a commit that referenced this issue Nov 29, 2023
@RobTillaart
Fix #15 refactor constructor
7b16dc4
RobTillaart added a commit that referenced this issue Nov 29, 2023
@RobTillaart
Fix #15 refactor constructor
bd5ce34
@RobTillaart RobTillaart linked a pull request Nov 30, 2023 that will close this issue
fix #15 refactor interface #16
Merged
RobTillaart added a commit that referenced this issue Nov 30, 2023
@RobTillaart
fix #15 refactor interface (#16)
23c1042 
- refactor constructor interface - breaking changes.
  - minimize conditional code. -- create SPI_CLASS macro to solve it.
- update readme.md
- update examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobTillaart RobTillaart

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #15 refactor interface RobTillaart/MCP_ADC
1 participant
@RobTillaart