Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serde] Deserialize+Serialize impl for (this crate's) T: Symbol implementors #45

Open
fogti opened this issue May 8, 2022 · 6 comments

Comments

@fogti
Copy link

fogti commented May 8, 2022

Symbols already get verified when used via resolve, so it should be no problem to provide appropriate serde::Deserialize and serde::Serialize implementations for symbols, such that the symbols and the interner can be easily serialized as part of an overall container structure.

fogti added a commit to fogti/gardswag that referenced this issue May 8, 2022
@bonsairobo
Copy link

Looks like a pretty easy PR. @Robbepop Do you think we could merge these changes soon?

@abs0luty
Copy link
Contributor

It looks like repository is a bit abandoned :\

@bonsairobo
Copy link

@abs0luty Yea I've since started using the lasso crate.

@Robbepop
Copy link
Owner

The repository is not avandoned officially but I am currently not having the time and energy to have focus for it.

@bonsairobo
Copy link

@Robbepop Hey no worries. Thanks for your contributions. I wish you the best.

@abs0luty
Copy link
Contributor

@Robbepop Hey that's fine, thanks you for all the stuff you've already made. I also wish you the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants