Don't insert to entry cache for the ShadowManagedLedger

RobertIndie · Sep 3, 2024 · d60d5bb · d60d5bb
1 parent 570edbd
commit d60d5bb
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
@@ -240,12 +240,8 @@ public void run() {
         ManagedLedgerImpl.TOTAL_SIZE_UPDATER.addAndGet(ml, dataLength);
 
         long ledgerId = ledger != null ? ledger.getId() : ((Position) ctx).getLedgerId();
-        // Don't insert to the entry cache when the entry payload is empty
-        final var duplicatedData = data.duplicate();
-        Commands.skipBrokerEntryMetadataIfExist(duplicatedData);
-        Commands.skipChecksumIfPresent(duplicatedData);
-        long metadataSize = duplicatedData.readUnsignedInt();
-        if (duplicatedData.readableBytes() > metadataSize && ml.hasActiveCursors()) {
+        // Don't insert to the entry cache for the ShadowManagedLedger
+        if (!(ml instanceof ShadowManagedLedgerImpl) && ml.hasActiveCursors()) {
             // Avoid caching entries if no cursor has been created
             EntryImpl entry = EntryImpl.create(ledgerId, entryId, data);
             // EntryCache.insert: duplicates entry by allocating new entry and data. so, recycle entry after calling