Deduplicated ColumnType type arguments are incorrect

[glacius-mitchell]

I believe the ColumnType type argument deduplication logic in ad03d2e was incorrect.

In particular, it assumed an omitted update type would default to the insert type, when in fact Kysely's update type defaults to the select type (see https://github.com/kysely-org/kysely/blob/0.27.4/src/util/column-type.ts#L41).

This led to some regressions in the types generated by kysely-codegen.

For instance, where we previously had these generated types

export type Int8 = ColumnType<string, bigint | number | string, bigint | number | string>;

export type Timestamp = ColumnType<Date, Date | string, Date | string>;

which expanded to

type Int8 = {
    readonly __select__: string;
    readonly __insert__: string | number | bigint;
    readonly __update__: string | number | bigint;
}

type Timestamp = {
    readonly __select__: Date;
    readonly __insert__: string | Date;
    readonly __update__: string | Date;
}

we now have these generated types

export type Int8 = ColumnType<string, bigint | number | string>;

export type Timestamp = ColumnType<Date, Date | string>;

which expand to

type Int8 = {
    readonly __select__: string;
    readonly __insert__: string | number | bigint;
    readonly __update__: string;
}

type Timestamp = {
    readonly __select__: Date;
    readonly __insert__: string | Date;
    readonly __update__: Date;
}

The new column types are overly strict on what types of values can be specified for an update.

Upvote & Fund

• We're using Polar.sh so you can upvote and help fund this issue.
• We receive the funding once the issue is completed & confirmed by you.
• Thank you in advance for helping prioritize & fund our backlog.

[glacius-mitchell]

Hi @RobinBlomberg, I see you've already addressed this in e4f54f4. Is there any chance that commit will make its way into a release soon? We're unable to upgrade at the moment due to the type regressions above. Thanks!

[glacius-mitchell]

@RobinBlomberg Any estimate on when the next release might come out with the commit linked in the post above? Thanks!

[RobinBlomberg]

Should be fixed now in kysely-codegen@0.17.0!