feat: Add --date-parser flag to control Postgres DATE type #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many people prefer to parse DATE columns as `strings` due to timezone issues with JS `Date`s. This adds a new flag, --date-parser, that allows the user to choose between using `Date` or `string` as the type for DATE columns.
brianmcd
commented
Oct 14, 2024
| @@ -0,0 +1,6 @@ | |||
| export const enum DateParser { | |||
| STRING = 'string', | |||
| TIMESTAMP = 'timestamp' | |||
There was a problem hiding this comment.
Wasn't sure if it made sense to call this TIMESTAMP or DATE, but I went with TIMESTAMP to match the existing generated types.
Closed
|
Great work! 🚀 This should be released shortly. |
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people prefer to parse DATE columns as
stringsdue to timezone issues with JSDates. This adds a new flag,--date-parser, that allows the user to choose between usingDateorstringas the type for DATE columns.I mostly just pattern matched against how
--numeric-parserwas implemented.Closes #194