Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: deep check for unsupported JSON schema #2116

Merged
merged 21 commits into from
Oct 25, 2024
Merged

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Oct 24, 2024

Implements #1500
Instead of #2115

2024-10-25T13:39:49.763Z warn: The final positive response schema of the endpoint contains an unsupported JSON payload type. {
  path: '/v1/user/list',
  method: 'get',
  reason: AssertionError [ERR_ASSERTION]: z.nan()

@RobinTail RobinTail added enhancement New feature or request prevention labels Oct 24, 2024
Copy link

coveralls-official bot commented Oct 25, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling d3bad56 on throw-map-set-used
into 7232a65 on master.

src/routing.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail marked this pull request as ready for review October 25, 2024 10:35
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant

@RobinTail
Copy link
Owner Author

✅ QA passed

@RobinTail RobinTail merged commit 1df86ca into master Oct 25, 2024
12 checks passed
@RobinTail RobinTail deleted the throw-map-set-used branch October 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prevention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant