Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style: Single statement blocks and empty returns #2156

Merged
merged 15 commits into from
Nov 8, 2024
Merged

Style: Single statement blocks and empty returns #2156

merged 15 commits into from
Nov 8, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Nov 7, 2024 •
edited
Loading

  • this also refactors implementation of makeNullableType depicter and improves its performance in mostly expected scenario
  • this also refactors a conditional return in the example of the generated client usage

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Nov 7, 2024
@RobinTail RobinTail marked this pull request as ready for review November 7, 2024 19:33
RobinTail
RobinTail commented Nov 8, 2024
View reviewed changes
tests/unit/endpoint.spec.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Nov 8, 2024
View reviewed changes
tests/unit/index.spec.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Nov 8, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 2eb3ad6 into master Nov 8, 2024
11 checks passed
@RobinTail RobinTail deleted the short-singlestatement-block branch November 8, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail