Feat: Empty response support #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature allows to avoid spinning up HTTP server when only HTTPS one is needed. It should enable best practices in the establishing secure communication channel. Changes to `ServerConfig` type: - `server` prop renamed to `http` - nested props `jsonParser`, `upload`, `compression`, `rawParser` and `beforeRouting` moved to the top level - all that included into the automated migration (ESLint rule) for v21
This should ease declaration and enable future improvements like #2099 Making `createServer()` to return an object having `servers` property instead of `httpServer` and `httpsServer`
Due to #2137 deprecated
RobinTail
changed the title
RobinTail
commented
Nov 19, 2024
RobinTail
commented
Nov 19, 2024
Make it slightly better in v21
RobinTail
commented
Nov 19, 2024
RobinTail
changed the title
RobinTail
changed the title
|
🚀 v21.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following HTTP status codes imply no content in response:
First one usually used for REST deletions.
There should be an easy way to describe and such things. Basically, there is no MIME type for those cases, because there is no body.
Current obstacles:
ResultHandler::positive::mimeTypesis currently non-empty array, eithermimeTypeis a stringz.never()is probably the best candidate for theschemabut it's unsupportedhowever,not: {}is used for describing fixed tuples, which the best depictionConsideration:
ifnevertype should be used in the client, because of no bodyundefined, becausenevermeans that.provide()does not return at all, such asthrowcase