Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS builds #55

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Fix macOS builds #55

merged 4 commits into from
Jul 5, 2022

Conversation

amatosov-rbx
Copy link
Contributor

@amatosov-rbx amatosov-rbx commented Jun 29, 2022 •
edited
Loading

Fix typo in the artifact upload path for aarch64 build
Add cleanup of the x86 artifacts to ensure architectures are not mixed up

@amatosov-rbx amatosov-rbx changed the title troubleshoot mac builds Fix macOS builds Jun 29, 2022
@amatosov-rbx amatosov-rbx marked this pull request as ready for review June 29, 2022 18:25
ZoteTheMighty
ZoteTheMighty approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NobleDraconian
Copy link

@ZoteTheMighty It seems the CLA bot is hung!

@ZoteTheMighty ZoteTheMighty merged commit fb96c39 into master Jul 5, 2022
@ZoteTheMighty ZoteTheMighty deleted the feature/feature/TroubleshootMacBuilds branch July 5, 2022 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZoteTheMighty ZoteTheMighty ZoteTheMighty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amatosov-rbx @NobleDraconian @ZoteTheMighty