Add command to add Artifactory Auth #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afujiwara-roblox
commented
Mar 5, 2024
| store.insert( | ||
| key.to_owned(), | ||
| Credentials { | ||
| username: "".to_owned(), |
There was a problem hiding this comment.
The artifactory auth format assumes a username field exists, but it isn't actually used to authenticate to Artifactory
ZoteTheMighty
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can already read Artifactory tokens, but Foreman has no way of adding the tokens them itself. This PR looks to add the command
artifactory-auth, that places the tokens in the expected format in the expected location.This PR also includes a minor version bump since we are adding behavior.