Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit rosbridge float32 -> int cast workaround #65

Closed
a-stickan opened this issue Aug 21, 2022 · 1 comment
Closed

Remove implicit rosbridge float32 -> int cast workaround #65

a-stickan opened this issue Aug 21, 2022 · 1 comment
Assignees

Comments

@a-stickan
Copy link
Contributor

Description

In #44, we discovered that rosbridge would convert floats of 0.0 to ints of 0 implicitly. This caused a lot of problems, and we implemented some scuffed workarounds to avoid it. The issue we posted in the rosbridge_suite repo has been resolved with the PR here, so it should be safe to remove the workarounds now.

Requirements

  • Remove the implicit casting workarounds
  • Test that the improved new method works
@a-stickan
Copy link
Contributor Author

Completed with #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants