Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings DecimalField should be Decimal type #1334

Conversation

jerryfletcher21
Copy link
Contributor

What does this PR do?

The warnings were caused by the validators MinValueValidator and MaxValueValidator inside a DecimalField.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@Reckless-Satoshi
Copy link
Collaborator

Thank you @jerryfletcher21 these warning were annoying. I believe they came in with the Django v5 update, I eliminated some of them but missed these ones. Please submit an invoice for 20K and a loong expiration time (+1 week) for a small Dev Fund tip 🚀

@Reckless-Satoshi Reckless-Satoshi merged commit 1f2a1ab into RoboSats:main Jun 16, 2024
1 check passed
@jerryfletcher21
Copy link
Contributor Author

jerryfletcher21 commented Jun 18, 2024

Please submit an invoice for 20K and a loong expiration time (+1 week) for a small Dev Fund tip 🚀

lnbc200u1pn8yxdcsp56mz8378rlywdj5dz0xlgnmsccz3rhpkgp4wt4nn67ty00sttc5rspp5xr9yw6hygphmf490dghnvkdrarnnn0kxaslyldlsy3ezug035xwqdqqxq9zf6sqcqzysrzjqdllz2m2fe9ukju5fdkjptcgehlkrv6xrswl7rgq4zrfws2d3yduwr8j0yqpv2sqqqqqqqlgqqqqp9sq2q9qxpqysgqzzrwkp5v06k9ae4j57uqya6l7lsz6g049xd4kqz57kvt7wx5qhk48h28vfe7fex9dgmrez9egpamwspjxahnl2rustygclhvraw877cqlsfkl0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants