New notifications #1356
Merged
New notifications #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoalaSat
commented
Jun 28, 2024
| # self.assertEqual( | ||
| # notifications_data[0]["title"], | ||
| # f"⚖️ Hey {data['taker_nick']}, you lost the dispute on your order with ID {str(trade.order_id)}." | ||
| # ) |
There was a problem hiding this comment.
Since the dispute resolution is an admin action, I'm not quite sure how to do it, ideas @Reckless-Satoshi ?
There was a problem hiding this comment.
I wonder whether we could directly call
Line 185 in dfd1cf5
There was a problem hiding this comment.
And fake the admin request with credentials? I'll take a look but for this kind of solutions they are always tricky
KoalaSat
force-pushed
the
new-notifications
branch
3 times, most recently
from
4d11c24 to
a9f1696
Compare
KoalaSat
force-pushed
the
new-notifications
branch
from
a9f1696 to
adbaa60
Compare
|
Merging this changes as agreed with @Reckless-Satoshi to figure out in other PR what to do with admin actions on tests |
|
I don´t understand why ruff is complaining on lines doesn´t even exist anymore 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Includes the necessary changes to be compatible with the existing notifications on web
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.