Fix lnproxy support #586

ghost · 2023-05-15T03:33:40Z

What does this PR do?

Fixes #560

This PR introduces a GitHub workflow. The workflow fetches the LnProxy relay list which is now stored in a standalone JSON file: https://github.com/lnproxy/lnproxy-webui2/blob/e2b8cf00393e0e2d1b71a346d24e6b7ac3ad95eb/assets/relays.json

The LnProxy API calls have also been updated to reflect the new structure used in that project.

Lastly this PR refactors the error handling slightly, since Tor-only relays seem to be a thing

Checklist before merging

[✅] Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.
[✅] If I added new phrases to the user interface, I have ran prettier cd frontend/static/locales; python collect_phrases.py to collect them for translation.

Note: The output of the collect_phrases.py script was a bit of a mess, so I didn't commit the changes

- Use POST instead of GET, so create and send a body parameter - Path is /spec/ instead of /api/, and list of relays from lnproxy will contain /spec already, so path parameter for ApiClient.post() is an empty string

doing this so that the “scripts” subfolder in .github/workflows can be added

Locale strings not added yet

Reckless-Satoshi

This so soo top! 🚀 Thank you very much for investing the time into getting this done.

I will find the time before tomorrow to run the UI and comment on it.

.github/workflows/lnproxy-sync.yml

Reckless-Satoshi · 2023-05-15T10:40:48Z

.github/workflows/scripts/lnproxy-sync.js

+const fs = require('fs');
+
+let rawRelays = JSON.parse(fs.readFileSync('./lnproxy_relays.json'));
+let formattedRelays = [];


There is a chance the /lnproxy/...relays.json does not see much action (or stops being maintained altogether). In such case, we might start adding ourselves new relays into ./frontend/static/lnproxies.json . This script will remove the new proxies we add. Maybe it's best to join existing and incoming proxies instead of starting blank [].

OK. I updated the script so that only new proxies that appear in /lnproxy/...relays.json will be added to the RoboSats list. We can easily make a more sophisticated merge in the future if needed.

Reckless-Satoshi · 2023-05-15T10:42:51Z

.gitignore

-### VirtualEnv template
-# Virtualenv
-# http://iamzed.com/2009/05/07/a-primer-on-virtualenv/
-[Bb]in


Awesome. On a recent PR I also moved a couple scripts into /scripts and deleted these lines from .gitignore . Maybe that creates a small merge conflict, not a problem though.

Reckless-Satoshi · 2023-05-15T10:55:58Z

.github/workflows/scripts/lnproxy-sync.js

+    clearnetCount++;
+  }
+
+  let relayName = `LNProxy ${relayType}${relayType === "TOR" ? torCount : ''}${relayType === "I2P" ? i2pCount : ''}${relayType === "Clearnet" ? clearnetCount : ''}`;


What about using the first 6 characters of the domain name ? e.g.:

let relayName = ${relayType}${relayType === "TOR" ? torCount : ''}${relayType === "I2P" ? i2pCount : ''}${relayType === "Clearnet" ? clearnetCount : ''} ${url.split('/')[2].substring(0,6)}

So it would read: TOR1 w3sqmn I think something in this line will make the dropdown menu more transparent for the user (rather than just a number, as the user does not know what is behind the number)

Yeah, this could go in many ways, there's probably more you could inspect on a relay other than just the name. For example status - some kind of ping to show whether the host is up (currently one of the tor lnproxy relays is down).

But first six is a good start :)

We will just need to keep an eye on the relay list - it's OK for now but something like "https://www.paidrelayproxiesfromthefuture.com" would render as "Clearnet1 www.pa"

#583)

…lnproxy

Reckless-Satoshi

It's looking great. Was just able to test it over TOR / mainnet. The filtered list showed me only the Clearnet1 server, not sure where the issue was, maybe the missing dependency settings.host .

I was able to get a request through, but the response was "Internal Error", I think though that everything is working fine with those three fixes I commented.

frontend/src/components/TradeBox/Forms/LightningPayout.tsx

- Change hook deps from settings.network to settings - routing_msat param updates for lnproxy API

ghost · 2023-05-16T20:25:53Z

Thanks! I've made the changes. Busy trying to figure out how I can also test these changes over TOR/mainnet. I've got the mainnet onion wired up, just figuring out how to expose my running npm as a hidden service.

ghost · 2023-05-17T01:15:33Z

Updated and tested on mainnet

Reckless-Satoshi · 2023-05-18T11:13:39Z

Tested successfully over Clearnet and TOR. The proxied payment made it through on the first attempt, completing the whole order process 🚀 I did not get to text the GH workflow, but we will see how that works :D

Thank you once again for this great work! @shyfire131 Please, accept a small tip from our devfund of 200K Sats. Submit an invoice with a +24h expiration time and from a proxy nodeid (...lnproxy!?).

ghost · 2023-05-18T19:38:32Z

lnbc2m1pjxv7wepp5uw0e9ggdjjc6rzutcy8gxrq73qp2scqn8mq4evnmr6k2xzk6y4nsdqqcqpjsp5w2vygz377ty752x96nwgywq7k970tggduszatlqs7nmkdazrx0lq9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqmqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcllczrm9kqyzs5sqqqqlgqqqqqeqqjqz45lq0j8d5jdslhrcj4gcz25zl05964fpn0m0krmmgdt876sf5kr0ve83yydylpzzrarf637vxqfh576pppwact74uya9q87j9df63sqr7ngjv

Reckless-Satoshi · 2023-05-19T10:52:10Z

lnbc2m1pjxv7wepp5uw0e9ggdjjc6rzutcy8gxrq73qp2scqn8mq4evnmr6k2xzk6y4nsdqqcqpjsp5w2vygz377ty752x96nwgywq7k970tggduszatlqs7nmkdazrx0lq9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqmqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcllczrm9kqyzs5sqqqqlgqqqqqeqqjqz45lq0j8d5jdslhrcj4gcz25zl05964fpn0m0krmmgdt876sf5kr0ve83yydylpzzrarf637vxqfh576pppwact74uya9q87j9df63sqr7ngjv

Payment Pathfinding Failed To Find Possible Route Probably the node is offline.

Reckless-Satoshi · 2023-05-21T11:27:46Z

b65a75953e044a64e42a1a3101e0edb60f241dfd89d963e90b48678091609552

ghost · 2023-05-21T12:07:10Z

Received, thanks! (apologies, I had deleted my comment with the invoice because it had a 24 HR expiry and not > 24 hours as you had commented)

+shyfire131 and others added 7 commits May 13, 2023 21:57

Use new lnproxy API

5b65ce9

- Use POST instead of GET, so create and send a body parameter - Path is /spec/ instead of /api/, and list of relays from lnproxy will contain /spec already, so path parameter for ApiClient.post() is an empty string

add lnproxy sync workflow

68f0e3e

Use new lnproxy JSON structure

a6ccdb1

Remove virtualenv

04c4133

doing this so that the “scripts” subfolder in .github/workflows can be added

Move workflow script to subfolder

344b422

Add translation support

f31d0b9

Locale strings not added yet

Merge branch 'main' into fix/lnproxy

3d8cd3e

Reckless-Satoshi reviewed May 15, 2023

View reviewed changes

Reckless-Satoshi and others added 8 commits May 15, 2023 10:26

Simplify coordinator updates, automatic migrations and collect statics (

53f8e0d

#583)

Delete commited proto files

f3e83ca

Run sync workflow weekly instead of hourly

9755f8c

Tweak display name for relays

50130f7

Update sync script to be append-only

12e5ccd

Merge branch 'main' of https://github.com/RoboSats/robosats into fix/…

7062964

…lnproxy

Use new naming convention for relays

fc81fc5

Fix bitcoinNetwork hydration

dcd6cfb

Reckless-Satoshi reviewed May 16, 2023

View reviewed changes

frontend/src/components/TradeBox/Forms/LightningPayout.tsx Outdated Show resolved Hide resolved

frontend/src/components/TradeBox/Forms/LightningPayout.tsx Outdated Show resolved Hide resolved

PR Feedback

2c8749e

- Change hook deps from settings.network to settings - routing_msat param updates for lnproxy API

+shyfire131 added 2 commits May 16, 2023 19:08

Actually set host in settings

a4dceef

Updated parsing of LnProxy response

db02063

ghost marked this pull request as ready for review May 17, 2023 01:15

Reckless-Satoshi merged commit 3bd7ade into RoboSats:main May 18, 2023

ghost deleted the fix/lnproxy branch May 22, 2023 02:49

ghost mentioned this pull request May 22, 2023

Fetch lnproxy relay list from lnproxy repo #608

Closed

1 task

Reckless-Satoshi assigned ghost Aug 3, 2023

Reckless-Satoshi added ⚡Eligible for Sats ⚡ This issue or pull request rewards bitcoin enhancement 🆙 New feature or request labels Aug 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix lnproxy support #586

Fix lnproxy support #586

ghost commented May 15, 2023

Reckless-Satoshi left a comment

Reckless-Satoshi May 15, 2023

ghost May 15, 2023

Reckless-Satoshi May 15, 2023

Reckless-Satoshi May 15, 2023

ghost May 15, 2023

ghost May 15, 2023 •

edited by ghost

Loading

Reckless-Satoshi left a comment

ghost commented May 16, 2023

ghost commented May 17, 2023

Reckless-Satoshi commented May 18, 2023 •

edited

Loading

ghost commented May 18, 2023

Reckless-Satoshi commented May 19, 2023

Reckless-Satoshi commented May 21, 2023

ghost commented May 21, 2023 •

edited by ghost

Loading

Fix lnproxy support #586

Fix lnproxy support #586

Conversation

ghost commented May 15, 2023

What does this PR do?

Checklist before merging

Reckless-Satoshi left a comment

Choose a reason for hiding this comment

Reckless-Satoshi May 15, 2023

Choose a reason for hiding this comment

ghost May 15, 2023

Choose a reason for hiding this comment

Reckless-Satoshi May 15, 2023

Choose a reason for hiding this comment

Reckless-Satoshi May 15, 2023

Choose a reason for hiding this comment

ghost May 15, 2023

Choose a reason for hiding this comment

ghost May 15, 2023 • edited by ghost Loading

Choose a reason for hiding this comment

Reckless-Satoshi left a comment

Choose a reason for hiding this comment

ghost commented May 16, 2023

ghost commented May 17, 2023

Reckless-Satoshi commented May 18, 2023 • edited Loading

ghost commented May 18, 2023

Reckless-Satoshi commented May 19, 2023

Reckless-Satoshi commented May 21, 2023

ghost commented May 21, 2023 • edited by ghost Loading

ghost May 15, 2023 •

edited by ghost

Loading

Reckless-Satoshi commented May 18, 2023 •

edited

Loading

ghost commented May 21, 2023 •

edited by ghost

Loading