Add collect_phrases pre-commit hook; run new collect phrases #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds collect_phrases pre-commit hook, simplifying the frontend development pipeline as now pre-commit is in charge of collecting new phrases for translation. Given that the hook will always pretty-format the collected .json files, the first "git commit" will always fail if there are new phrases; the second one will succeed.
This PR collects all i18n phrases with the new ordered dict by @JooVLC to ensure consistent ordering cross-platform.
Checklist before merging
pip install pre-commit
, thenpre-commit install
. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.