-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core-lightning as backend lightning node vendor #611
Conversation
* Add cln service * Add hodlvoice Dockerfile and entrypoint
* Add LNNode vendor switch
Hey @daywalker90 , It seems we have 2 undefined |
hmm there is no specific failure reason to give. So for 470 its just "Pending" and 475 "Failed" (and not pending!) |
btw in practice i've never seen it return with a non-error "pending" i wouldn't even know when this can happen |
In lnd.py I see these I added a commit defining these two |
yes looks good. |
What does this PR do?
Fixes #196 . This PR adds support for core-lightning (CLN) as lightning node vendor. This PR merges into main the work of @daywalker90 for the rewarded task #196 .
Coming from :
#593
#435
#433
#431
Some considerations
Using CLN on mainnnet as the RoboSats backend is strongly discouraged. Yet, using it on testnet and breaking things, is strongly encouraged. CLN has been very little tested as a RoboSats backend compared to LND, and it is likely we still have to find and fix some bugs.
Only the Dockerfile in
docker/cln
will have all the necessary libraries to work as a RoboSats backend. Our Dockerfile currently builds CLN formElementsProject/lightning
and the grpc plugin fromdaywalker90/lightning#hodlvoice
GitHub repositories . Any other docker image will not work.Quoting @daywalker90 in #593
Checklist before merging
pip install pre-commit
, thenpre-commit install
. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.