Fix bug in discount field #614
Conversation
Fixing the type handlePremiumChange function to handle the discount to the right type (React.ChangeEventHandler<HTMLInputElement | HTMLTextAreaElement>) Using the correct type of handlePremiumChange function, then deconstructing the "value" var from the event.target Using Number(value) in declaration of "newPremium", instead of using multiplication with number and string To not affect another methods using "premium" var, I used isNaN func to make a check and set the initial value of "premium" var to zero (if is NaN) or newPremium (when valid number is entered) The fix in the bug is the line "premium: isNaN(newPremium) || value === '' ? '' : premium," in setMaker. That makes the "premium" var to be set to zero when the input is empty or not a number, allowing the user to input the "-" (minus sign) and not entering 0 as before.
|
@Reckless-Satoshi, I tested the changes and it appears to be working great, but I will run more tests soon. If anyone wants to test too be welcolme. After more tests I will put the PR for review. Another detail is I had to change "frontend/static/locales/collect_phrases.py" because the pre-commit was running in a loop. |
| with open(locale, "w", encoding="utf-8") as f: | ||
| json.dump(new_phrases, f, ensure_ascii=False) | ||
| # don't change the file if there aren't new keys (order matters) | ||
| if new_phrases != old_phrases: |
There was a problem hiding this comment.
thanks for this fix! Indeed, there was a bit of a formatting-recursion-hell :)
| updateAmountLimits(limits.list, fav.currency, premium); | ||
| setMaker({ | ||
| ...maker, | ||
| premium: isNaN(newPremium) || value === '' ? '' : premium, |
There was a problem hiding this comment.
This fix should work well!
|
If you agree, I believe this PR is ready to be marked as ready for review (and subsequently merged 🚀 ) Please, accept a tip of 40K Sats from the devfund. Submit an invoice with a long expiration time from a proxy node id :) |
I agree, I will change the PR. |
Merging! Thank you for your top contributions! 🚀 Don't forget the invoice :D Remember that some mobile wallets will be turned-off when they are in the background and cannot receive payments. |
Fixing the type handlePremiumChange function to handle the discount to the right type (React.ChangeEventHandler<HTMLInputElement | HTMLTextAreaElement>)
Using the correct type of handlePremiumChange function, then deconstructing the "value" var from the event.target
Using Number(value) in declaration of "newPremium", instead of using multiplication with number and string
To not affect another methods using "premium" var, I used isNaN func to make a check and set the initial value of "premium" var to zero (if is NaN) or newPremium (when valid number is entered)
The fix in the bug is the line "premium: isNaN(newPremium) || value === '' ? '' : premium," in setMaker. That makes the "premium" var to be set to zero when the input is empty or not a number, allowing the user to input the "-" (minus sign) and not entering 0 as before.
What does this PR do?
Fixes #532
This PR fix the bug in discount field changing the function
handlePremiumChangein "frontend/src/components/MakerForm/MakerForm.tsx".This changes "frontend/static/locales/collect_phrases.py" too, because the pre-commit was running in loop, changing the locales's json. I added a comparison in the python script to not update the json if he no has changes.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.