Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfiguration of Annotators #212

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

evankapi
Copy link
Contributor

@evankapi evankapi commented Mar 9, 2021

This extension includes reconfigurable annotators and updates to the query system to handle different inputs / outputs of annotator setups. Those setups are also considered during the pipeline planning via the query service.

@bbferka
Copy link
Collaborator

bbferka commented Mar 17, 2021

@Sanic you'll look through this ? if you need help let me know. It's been a while since I looked at the code. I would def not recommend merging without having the code coverage increase. Some of these changes affect basic pipeline planning capabilities and we should make sure that they still work

@Sanic
Copy link
Contributor

Sanic commented Mar 17, 2021

Hi @bbferka
Yep! We already had a discussion about it and i also asked @evankapi to test the reconfigure capabilities. He also wanted to work on a couple of other things before we continue with this PR.

But you also raise a good point to test also the basic planning capabilities. @evankapi Could you please keep that in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants