Use libboost-* packages instead of deprecated boost and boost-cpp packages #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh no, how did that slip through :( |
|
Let's rebuild the Windows packages - do you think we should rebuild other platforms too? |
I do not think we need the rebuild on humble, the run_constrained dep of ros2-distro-mutex with boost-cpp have saved us in this case I guess. |
|
Oh I understand now .. thanks, will stop it. |
|
Actually, let's run it as an "exercise". I'd like to see how easy/hard it is to rebuild in one go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in RoboStack/ros-noetic#448 (comment), the use of deprecated packages that were not pinned in pinnings was basically causing the pinning to be ignored. With respect to ROS Noetic, we do not need to do any kind of rebuild as we have a
run_constrainedonboost-cppinros2-distro-mutex, that is not there in ROS Noetic.