-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable rmw_cyclonedds_cpp package on Windows #152
Enable rmw_cyclonedds_cpp package on Windows #152
Conversation
Cool, a bunch of failures in patch as many ros2_controllers were upstreamed and released. |
For the time being I just comment ros2_controllers, as it is unrelated to the PR, and also as those patches could change pending on ros-controls/ros2_controllers#1053 . |
Failure in https://github.com/RoboStack/ros-humble/actions/runs/8054558394/job/21999389331?pr=152 :
|
From the error, it seems that |
Cool, found a related issue from 2021: eclipse-iceoryx/iceoryx#868 . In a nutshell, I guess official ROS 2 binaries use static libraries for |
I tried to build iceoryx with |
@Tobias-Fischer the PR seems successful. What do you think of building iceoryx as static for now? |
Works for me :). I'll merge here - could you please test whether the resulting packages work? |
Works for me too. Thanks a lot! saved me from a headache. For context: the default RMW implementation seems to be massively throttling messages on my machine. I added a video which shows the before/after of changing the RMW implementation to cyclone. I feel like what I was experiencing should not be normal, for the default implementation, but anyhow.. It seems to work nicely now with cyclone. In the video im publishing a massive amouint of messages, but the same type of throttled/lossy behaviour happened for publishers at 20Hz even. working.mp4 |
Thanks @edvart-ros ! Just for future reproducibility, can you also report your |
|
Fix #151