Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nova 2 #139

Merged
merged 76 commits into from
Jan 29, 2025
Merged

Nova 2 #139

merged 76 commits into from
Jan 29, 2025

Conversation

flimdejong
Copy link

Comments for the reviewer

Pre pull request checklist:

Code Quality
  • Is the code is understandable and easy to read
  • Changes to the code comply with set clang-format rules
  • No use of manual memory control (e.g new/malloc/colloc etc)
  • Are (only) smart pointers used?
Testing
  • All tests are passing.
  • I added new / changed existing tests to reflect code changes (state why not otherwise!)
  • I tested my changes manually (Describe how, to what extent etc.)
Commit Messages
  • Commit message is saying what has been changed, why it was changed? Remember other developers might not know
    what the problem you are fixing was. Note also negative decision (e.g., why did you not do particular thing)
    TLDR: Commit message are comprehensive
  • Commit messages follows the rules of https://chris.beams.io/posts/git-commit/

flimdejong and others added 30 commits September 12, 2024 10:37
@flimdejong
added code descriptions
d467416
@flimdejong
fixed descriptions
baad6ae
@flimdejong
added proto pb2 python files
2300593
@flimdejong
added better documentation of roboteam_networking
91310d0
@flimdejong
Added more documentation + docker volume to change SSL-game-controlle…
c1c80d0 
…r settings
@flimdejong
Added more proto files
fc42efc
@flimdejong
add (updated) proto files for manipulating GC
c62bad2
@flimdejong
add initial code for RL
987e39c
@flimdejong
fix RL weird errors
5adda7e
@flimdejong
Fixed proto files finally (checked if build works)
50b91a6
@flimdejong
added initial support for kubernetes using docker
c236d5b
@flimdejong
fixed small error in kube.yaml
7d2600b
@flimdejong
Added train.py file for initial testing
fa85ccc
@flimdejong
Fix docker -compose file
5232577
@flimdejong
Made 5/8 programs running succesfully on kubernetes
593c846
@flimdejong
GC + PrimAI + Observer + Hub + Interface + Sim launched succesfully
da18d1a
@flimdejong
Kube pod working for all AI except secondary or Tigers (ports not tes…
7f94d86 
…ted)
@aelhabashy
fix getstate, changed reset state
245a0aa
@aelhabashy
Merge branch 'nova' of https://github.com/RoboTeamTwente/roboteam int…
f2e5b5a 
…o nova
@flimdejong
Fixed dockerfile + added Tigers AI
f3c018a
@flimdejong
Merge Adham's work with my update
4bc490a
@flimdejong
Add tigers_sumatra as submodule
31b2c37
@flimdejong
Fix spelling
b756e0f
@flimdejong
Updated Dockerfile and kube.yaml file (tested on hostnetwork)
d2365df
@crinagurev
ray cluste and test file
6be3014
@crinagurev
Commit again
ba59fb7
@flimdejong
Added more compute + py3.10 image
e4d89eb
@flimdejong
Reorganisation of code
1ce8564
@flimdejong
Changed useReferee to true (default on)
063104a
@flimdejong
Added resetReferee functionality + slight reorganisation and added ch…
4acb021 
…angeGameState
flimdejong and others added 27 commits November 18, 2024 11:53
@flimdejong
added yaml file to launch workers + sim simultaneously
a5df29c
@flimdejong
added version for ray
4d2d0d3
@flimdejong
Updated train.py file for Ray
396e527
@flimdejong
Initial version working on ray cluster (does not return observations …
15b0666 
…yet)
@flimdejong
Runs on Ray cluster successfully. Changed resource-limits, fixed ray …
9cae1bb 
…networking and environment.
@flimdejong
MVP of environment finished and tested
fd6de81
@flimdejong
slight update to env
ee75ee6
@flimdejong
Increase max_attempts for teleport ball
5e077f0
@flimdejong
Cleaning up rl folder to prepare for cpp addition
fac548d
@flimdejong
Beta test zmqpp library addition to send and receive data from py/cpp
b153600
@flimdejong
RLInterface created & integrated and tested briefly
cf6ae7c
@flimdejong
Integrated dynamic attacker allocation in code. Tested with static va…
4c6929d 
…lues but dynamic values are successfully received
@flimdejong
Fixed loss of state (now tested, also with grids), ready to train RL
b7e3a41
@flimdejong
Tested dynamic attackers manually. Need to test with Ray.
acebe24
@flimdejong
Receiver role is more stable when there are multiple robots in the sa…
1158754 
…me spot
@aelhabashy
fixing formation
d5ee857
@aelhabashy
Merge branch 'nova' of https://github.com/RoboTeamTwente/roboteam int…
0daac0d 
…o nova
@flimdejong
Added teleport robots to speed up sim and fixed zmq_publisher
efbdfea
@flimdejong
Added stickiness factor to attackergrids part 2 (with minor readabili…
3d17077 
…ty tweaks)
@flimdejong
Fixed both sides of team taking new formation
674fb06
@flimdejong
Update ray-cluster file
ba8f916
@flimdejong
Updated environment files (teleportball, teleportrobot, general fixes)
a224e9f
@flimdejong
changed submodule and slight changes to cluster for easier testing
8bbd3a5
@flimdejong
Increased erforce autoref memory limits
6a3e18e
@flimdejong
added workaround for UDP multicast ray
4cf971c
@flimdejong
Created workaround for ray worker UDP
20c9817
@flimdejong
Fixed communication and added ZMQ to UDP partly
c40c92a
@flimdejong flimdejong merged commit 4e82dfb into master Jan 29, 2025
5 checks passed
@flimdejong flimdejong deleted the nova_2 branch January 29, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaKady HamzaKady HamzaKady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flimdejong @HamzaKady @aelhabashy @crinagurev