Previously, the source version of CTKP was hard coded, but now the pa… #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rser collects the latest version from the CTKP mainfest on github.
|
I had this hard coded because the version in the manifest was an older version than the one they wanted deployed at the time, but this is really the way to go. There's still a bit of a risk of the properties or structure changing and breaking things for such a rapidly evolving data source, but it would be nice to have it update automatically, so it's a trade off. I'll try to see what's changed since this was first written and build the latest and then we can get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rser collects the latest version from the CTKP mainfest on github.