-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LCM traffic on macOS Sequoia #303
Conversation
8acf4a9
to
1f488ff
Compare
See #22572 for re-enabling the unit test that was previously failing. Builds on mac-arm-sequoia-clang-bazel-experimental-everything-release and mac-arm-sequoia-unprovisioned-clang-bazel-experimental-everything-release, which were run using this PR and the PR on |
Perhaps both +@rpoyner-tri and +@jwnimmer-tri would like to look at this fix. What are your thoughts on updating documentation, especially user-facing (in case anyone else has this issue on macOS)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should update the documentation. Perhaps a new entry in https://drake.mit.edu/troubleshooting.html and then the class overview for DrakeLcm can link to that new section.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tyler-yankee)
@tyler-yankee FYI for drake-ci, we usually let Kitware actually hit the merge button when you're ready, rather than the reviewers merging. |
Sounds good, I'm going to wait until we find a fix for #22587 before merging in anything new. |
Addresses #22322. Network config changes don't persist on the CI images, so this change has to go in a setup script that is run each time Jenkins deploys a VM. Currently, all other macOS setup scripts only run once, or they don't run on both provisioned and unprovisioned images. Running this command is required on Sequoia and harmless on Sonoma.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)