Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double pendulum demo #22

Closed
wants to merge 7 commits into from
Closed

Double pendulum demo #22

wants to merge 7 commits into from

Conversation

stonier
Copy link
Contributor

@stonier stonier commented Jul 26, 2017

Express purpose of this demo is to test/verify that installed data files and lookup are working properly.

See #11.

@stonier
Copy link
Contributor Author

stonier commented Jul 26, 2017

Currently falls over in a compile with lcmtypes headers not being found properly by other headers in the install:

make -j5
[ 33%] Built target simple_continuous_time_system
[ 50%] Building CXX object apps/double_pendulum/CMakeFiles/double_pendulum_demo.dir/double_pendulum_demo.cc.o
[ 66%] Building CXX object apps/double_pendulum/CMakeFiles/double_pendulum_demo.dir/sdf_helpers.cc.o
In file included from /mnt/mervin/workspaces/shambhala/drake_cmake_installed/apps/double_pendulum/double_pendulum_demo.cc:11:0:
/opt/drake/include/drake/multibody/rigid_body_plant/drake_visualizer.h:9:38: fatal error: drake/lcmt_viewer_draw.hpp: No such file or directory
compilation terminated.

Some typical locations for that header:

$ locate lcmt_viewer_draw.hpp
/mnt/mervin/workspaces/drake/build/drake/lcmtypes/drake/lcmt_viewer_draw.hpp
/mnt/mervin/workspaces/drake/build/install/include/lcmtypes/drake/lcmt_viewer_draw.hpp
/opt/drake/include/drake/lcmtypes/drake/lcmt_viewer_draw.hpp

@jwnimmer-tri
Copy link
Contributor

jwnimmer-tri commented Jul 26, 2017

Wow. We should definitely not copy this double_pendulum code wholesale out of Drake. The double_pendulum example code is incomplete and will be undergoing significant rework within Drake as the new SDF parser grows up. I would suggest using RigidBodyTree in the example, since that's what most people should be using right now. Something like an example of a main program that loads an SDF or URDF and forward-simulates it for a few seconds, probably with drake_visualizer running to watch it live.

@jwnimmer-tri
Copy link
Contributor

Maybe the https://github.com/RobotLocomotion/drake/tree/master/drake/examples/particles would be a better example. Possibly that example should even move into shambhala exclusively, since its purpose was onramp tutorial.

@stonier
Copy link
Contributor Author

stonier commented Jul 26, 2017

Yes, aware of the upcoming changes, but wasn't overly concerned about the right example yet (copy/paste is relatively free short term) but instead finding a means of express testing the lack of data support.

Definitely better is to just have a simple test that loads an sdf file in drake as that validates data installation in the most minimal way, but I'll need some additional time to write a small program to get there.

This PR for the moment will still be useful to uncover the lcmtypes problem (doesn't have to merge).

I like the idea of moving the particle demonstration.

@jamiesnape
Copy link
Contributor

Depends on RobotLocomotion/drake#6817.

@stonier
Copy link
Contributor Author

stonier commented Aug 18, 2017

sdformat is now linking and passing, so closing this PR.

@stonier stonier closed this Aug 18, 2017
@stonier stonier deleted the stonier/pendulum branch August 18, 2017 19:28
@jamiesnape jamiesnape removed their request for review June 17, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants