Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vive teleop #351

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Vive teleop #351

wants to merge 49 commits into from

Conversation

jmcculloch2018
Copy link

@jmcculloch2018 jmcculloch2018 commented Nov 14, 2018

Created script for controlling robot using vive
Made changes to procman config and docker_run to make teleop easier to run
Updated documentation


This change is Reviewable

@rlg-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@gizatt
Copy link
Collaborator

gizatt commented Nov 14, 2018

Jenkins please test

(added to whitelist)

Copy link
Collaborator

@gizatt gizatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Two nits, but if it passes CI I'm happy with it!

(The Vive teleop script could certainly use cleaning up, but that's the same for the hydra and gamepad teleop scripts, so I'm OK leaving that for some future refactoring.)

doc/vive_guide.md Outdated Show resolved Hide resolved
setup/docker/docker_run.py Show resolved Hide resolved
@manuelli
Copy link
Collaborator

I'd like to take a look at this before it gets merged, just to make sure it isn't messing up any core code. Should be able to get to it tonight.

@peteflorence
Copy link
Collaborator

Hey @jmcculloch2018 and @gizatt , would we like to merge this sometime soon?

Looks like some very useful stuff in here, for example I just cherry-picked this commit: 8f0bf6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants