Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Benchmarking]Add the cases to measure the start up time #363

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

minggangw
Copy link
Member

The case has two operations:
1. Initialize the module.
2. Create a node in ROS system.

Fix #362

The case has two operations:
    1. Initialize the module.
    2. Create a node in ROS system.

Fix RobotWebTools#362
@qiuzhong
Copy link
Collaborator

@minggangw , there are segment fault errors in the CI build logs. I tried this PR with latest ros2 package locally and the errors happened as well. It seems the ros2 package changed recently.

If you want to let this PR pass temporarily, please add these test suites to blacklist:
["test-cross-lang.js", ""test-interactive.js", "test-multi-nodes.js", "test-single-process.js"]

@minggangw
Copy link
Member Author

This issue should be fixed by ros2/rmw_fastrtps#210, so let's retry with the next nightly build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.557% when pulling dae50c2 on minggangw:add-startup-benchmark into 8e96296 on RobotWebTools:develop.

@minggangw
Copy link
Member Author

Based on the latest binary packages, the tests passed. I will merge this PR soon.

@minggangw minggangw merged commit 7061517 into RobotWebTools:develop Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants