Add node 13-17 support, bump to v0.21.0 #825
Conversation
0. package.json * Bumped to version 0.21.0 * Support for node 13-16 required forking and customizing the following packages: @rclnodejs/ref-array-di @rclnodejs/ref-napi @rclnodejs/ref-struct-di Revised package dependencies to use the 3 packaged listed above * Added jsdoc as devDependency 2. test-security-related.js Fixed minor assertion error caused by change in Nodejs error message. 3. Docs * Updated README.md, Build.md and npmjs-readme.md to expand valid versions of node 13-16. * Modified docs/Makefile to use `npx` to run jsdoc to generate api documentation
Increased nvm to v0.39.1 Increased node to v16.13.1
Dockerfile - added user 'rclnodejs' as default user for running tests - requires <ros-install>/ file mode of 777 in order for the compile-test.js script to install compiled test messages into the ros distro. test-signals.js - added 60 sec timeout to avoid race condition on slower systems
|
On linux running install with node16 as root is a PIA with permissions issues. No such issues with node 12 & 14. Thus the zillion commits as I slowly convert from running scripts and test suite to non-root user. Grant me patience! |
wayneparrott
changed the title
Updated for use with node v13-v17, bump to v0.21.0 (#825) 0. package.json * Bumped to version 0.21.0 * Support for node 13-17 required forking and customizing the following packages: @rclnodejs/ref-array-di @rclnodejs/ref-napi @rclnodejs/ref-struct-di Revised package dependencies to use the 3 packaged listed above * Added jsdoc as devDependency * Moved dtslint pkg to devDependents 2. test-security-related.js Fixed minor assertion error caused by change in Nodejs error message. 3. Docs * Updated README.md, Build.md and npmjs-readme.md to expand valid versions of node 13-17. * Modified docs/Makefile to use `npx` to run jsdoc to generate api documentation 4. Circleci - refactored config.yml to use nvm 0.39 and run test suite on node 12, 14, 16, 17 5. appveyor.yml - use nvm 0.39 and run test suite on node 12, 14, 16, 17 6. .travis.yml - use nvm 0.39 and run test suite on node 12, 14, 16, 17 7. Fix cpplint error for node > 12 in rcl_bindings.cpp
|
In the very beginning of |
|
@felixdivo hi, the node tag is dynamically generated from https://img.shields.io/node/v/rclnodejs. When we publish the next rclnodejs release to npmjs.com the tag should be updated with the latest range of supported node versions. |
|
Ah okay, sorry for the bump. |
|
There is an update, saying that this crash issue (from node v13 to v16) has been fixed on node v17, but with performance regression. @wayneparrott |
|
I verify rclnodejs v0.20.1 with node v17.4.0 and the crash is gone. |
Was this build using the original |
|
I'm running rclnodejs v0.21.0 with node v17.8.0 on aarch64 and ros2 galactic and I'm experiencing the cannot reinterpret from nullptr pointer. I found a work around earlier but, I've since flashed the computer and now, I'm unfortunately debugging something I already solved. I think I may have reverted node to 16 and used the previously mentioned solution. Should I be experiencing this error still? |
Public API Changes
none
Description
packages:
@rclnodejs/ref-array-di
@rclnodejs/ref-napi
@rclnodejs/ref-struct-di
Revised package dependencies to use the 3 packaged listed above
versions of node 13-16.
documentation
Fix #735 #717