Removed memory leak from MarkerClient #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the internal that.markers map did not have duplicates, the rootObject.children list still remembered a reference to the old marker and thereby prevented the garbage collector from eating it.
rctoris
added a commit
that referenced
this pull request
Nov 21, 2013
Removed memory leak from MarkerClient
|
+1! We were seeing browsers crash after having the market client up for more than an hour. Glad this is fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the internal that.markers map did not have duplicates, the rootObject.children list still remembered a reference to the old marker and thereby prevented the garbage collector from eating it.