Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribe function's queue_length default value is inconsistent between document and code #280

Closed
ledmonster opened this issue May 15, 2017 · 2 comments

Comments

@ledmonster
Copy link
Contributor

subscribe function's queue_length default value is inconsistent between document and code.

Document saids:

queue_length – the size of the queue to buffer messages. Messages are buffered as a result of the throttle_rate. Defaults to 1.

But code's default is 0.

        subscribe_args = {
          "sid": sid,
          "msg_type": msg.get("type", None),
          "throttle_rate": msg.get("throttle_rate", 0),
          "fragment_size": msg.get("fragment_size", None),
          "queue_length": msg.get("queue_length", 0),
          "compression": msg.get("compression", "none")
        }

Which one should be standard ?

@mvollrath
Copy link
Contributor

Also defaults to zero in roslibjs

@pedro1713
Copy link

Queue size = 0 would indicate an infinite queue. I would assume that defaulting to an infinite queue is reasonable to avoid missing messages, though not entirely sure this is the original intent.
Maybe we should correct the documentation rather than the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants