-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serializing a list containing binaries doesn't work #313
Comments
Behery
pushed a commit
to Behery/rosbridge_suite
that referenced
this issue
Jan 9, 2018
has_binary now checks for lists of binary objects
Behery
pushed a commit
to Behery/rosbridge_suite
that referenced
this issue
Jan 9, 2018
Checks for lists of binary objects inside the objects as well as dictionaries
Behery
pushed a commit
to Behery/rosbridge_suite
that referenced
this issue
Jan 9, 2018
Checks for lists of binary objects inside the objects as well as dictionaries
Behery
pushed a commit
to Behery/rosbridge_suite
that referenced
this issue
Jan 9, 2018
Checks for lists that have binary content as well as dicts
Behery
pushed a commit
to Behery/rosbridge_suite
that referenced
this issue
Jan 16, 2018
Checks for lists that have binary content as well as dicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the
rosbridge_library.protocol
tries to serialize an object, the has_binary function doesn't check for list of binaries; it only checks if the object itself is binary, or if it's adict
that has binary in it.This caused the serialize function to try and json serialize it (which would fail in that case) and the service call doesn't respond back to the client.
The text was updated successfully, but these errors were encountered: